Re: [PATCH] net: trivial MLX4_DEBUG dependency fix.

From: Roland Dreier
Date: Thu May 10 2007 - 14:20:35 EST


> IMHO default configs must be aimed at production usage scenarios, so
> are better off without debugging enabled by default. Except if the
> driver is really new / EXPERIMENTAL where the goal is to get it tested
> out by all users asap (and no production systems would be using it
> anyway).

I agree, but I would hope that MLX4_DEBUG *is* enabled in production.
It doesn't print anything or introduce any measurable overhead except
for slightly larger code size unless the debug level is explicitly
increased, so the only reason to turn it off is if a few bytes of code
makes a big difference to you (hence making it selectable only if
EMBEDDED is selected).
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/