Re: slub-i386-support.patch

From: Christoph Lameter
Date: Thu May 10 2007 - 16:31:31 EST


On Thu, 10 May 2007, Andrew Morton wrote:

> > Though when I look at the patchset (copied below), I do wonder why
> > it puts a quicklist_trim() into i386's cpu_idle() and flush_tlb_mm():
> > neither is where I'd expect us to be secretly freeing pages. Ah,
> > several arches do it in cpu_idle(): how odd, oh well.
>
> Christoph, could you please check that this is justified?

This has been that way for years for ia64 and sparc64. quicklist page
freeing needs to be synced with the tlb flushing since page table pages
may be flushed with the pages gathered in the tlb_mm struct. Dave Miller
set this up initially as far as I can tell. He could probably give more
details on why this was done historically.

ccing Dave.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/