Re: [RFC] memory hotremove patch take 2 [01/10] (counter ofremovable page)

From: KAMEZAWA Hiroyuki
Date: Thu May 10 2007 - 21:09:23 EST


On Thu, 10 May 2007 11:00:31 -0700 (PDT)
Christoph Lameter <clameter@xxxxxxx> wrote:

> On Wed, 9 May 2007, Yasunori Goto wrote:
>
> >
> > +unsigned int nr_free_movable_pages(void)
> > +{
> > + unsigned long nr_pages = 0;
> > + struct zone *zone;
> > + int nid;
> > +
> > + for_each_online_node(nid) {
> > + zone = &(NODE_DATA(nid)->node_zones[ZONE_MOVABLE]);
> > + nr_pages += zone_page_state(zone, NR_FREE_PAGES);
> > + }
> > + return nr_pages;
> > +}
>
>
> Hmmmm... This is redoing what the vm counters already provide
>
> Could you add
>
> NR_MOVABLE_PAGES etc.
>
> instead and then let the ZVC counter logic take care of the rest?
>
Okay, we'll try ZVC.

Thanks,
-Kame

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/