Re: [patch 02/28]xen: Add nosegneg capability to the vsyscall pagenotes

From: Jeremy Fitzhardinge
Date: Fri May 11 2007 - 16:25:21 EST


Roland McGrath wrote:
>> + * It should contain:
>> + * hwcap 0 nosegneg
>> + * to match the mapping of bit to name that we give here.
>>
>
> This comment still needs s/0/1/ to match the code. Given that the actual
> bit is now defined in the macro in another file, perhaps the comment should
> say more about it than just a magic 1.
>

Crap, I thought I had 1) understood it, and 2) fixed it. I guess I
skipped 1 and therefore overlooked 2.

J
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/