Chuck Ebbert wrote:Robert Hancock wrote:Why not just document the error messages?It certainly seems useful when debugging hotplug issues or random SATA+ ehc->i.serror & SERR_TRANS_ST_ERROR ? "TransStatTransErr "I'm not really convinced whether this is necessary. The human readable
: "",
+ ehc->i.serror & SERR_UNRECOG_FIS ? "UnrecogFIS " : "",
+ ehc->i.serror & SERR_DEV_XCHG ? "DevExchanged " : "" );
form is also a bit cryptic and can get quite long. So, mild NACK from
me.
problems which end up being caused by communication problems. Without
this output, Joe User stands no chance of figuring out what's going on,
and neither does Joe libata Developer unless they really care to dig
through the spec and count bits to figure out what they mean. At least
with this you can see that there was a CRC error, etc. and go from that..
And the scsi ones too, I can't seem to find what the sense codes mean.
They are well documented elsewhere - the standard documents. For sense
codes, t10.org. For SError bits, t13.org. You can get drafts free of
charge.