Re: [patch 2/2] Slab allocators: Drop support for destructors

From: Paul Mundt
Date: Fri May 11 2007 - 21:34:12 EST


On Fri, May 11, 2007 at 09:57:51AM -0700, clameter@xxxxxxx wrote:
> There is no user of destructors left. There is no reason why we should
> keep checking for destructors calls in the slab allocators.
>
> The RFC for this patch was discussed at
> http://marc.info/?l=linux-kernel&m=117882364330705&w=2
>
> Destructors were mainly used for list management which required them to take a
> spinlock. Taking a spinlock in a destructor is a bit risky since the slab
> allocators may run the destructors anytime they decide a slab is no longer
> needed.
>
> Patch drops destructor support. Any attempt to use a destructor will BUG().
>
> Cc: Pekka Enberg <penberg@xxxxxxxxxxxxxx>
> Cc: Paul Mundt <lethal@xxxxxxxxxxxx>
> Signed-off-by: Christoph Lameter <clameter@xxxxxxx>
>
Acked-by: Paul Mundt <lethal@xxxxxxxxxxxx>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/