Re: [RFC PATCH] kbuild: silence section mismatch warnings

From: Sam Ravnborg
Date: Sat May 12 2007 - 02:29:33 EST


On Fri, May 11, 2007 at 04:22:28PM -0500, Kumar Gala wrote:
>
> On May 11, 2007, at 4:08 PM, Sam Ravnborg wrote:
>
> >----- Forwarded message from Sam Ravnborg <sam@xxxxxxxxxxxx> -----
> >
> >Forgot lkml in first mail...
> >
> > Sam
> >
> >Subject: [RFC PATCH] kbuild: silence section mismatch warnings
> >From: Sam Ravnborg <sam@xxxxxxxxxxxx>
> >Date: Fri, 11 May 2007 23:03:46 +0200
> >User-Agent: Mutt/1.4.2.1i
> >To: Chris Wedgwood <cw@xxxxxxxx>, Andrew Morton <akpm@xxxxxxxx>,
> > "David S. Miller" <davem@xxxxxxxxxx>,
> > Russell King <rmk@xxxxxxxxxxxxxxxx>,
> > Satyam Sharma <satyam.sharma@xxxxxxxxx>
> >Cc: sam@xxxxxxxxxxxx
> >
> >Following patch allow us in specific places to silence section
> >mismatch warnings.
> >There is a few legitime places that modpost does not yet recognize
> >where
> >reference from .text to .init.text (likewise for data) are legitime.
> >This allow us to spot the few places and annotate them so we do not
> >get false warnings that in the end will let real warnings pass.
> >
> >The annotation is simple to grep for so revieing all uses in a few
> >months time are trivial. It is assumed that a few places will
> >use this to shut up the warning as replacement for the real fix.
> >But these cases are esay to spot and to fix up.
>
> Its unclear if you expect that some things will be tagged
> __init_refok/__initdata_refok forever or if we'll find some way to
> fix/change the code so the things tagged no longer need it.

A few places will need the __init_refok tag forever.
But as Satyam points out it will likely be misused.

So the __init_refok is introduced to stay.

akpm pointed out in private mail that I need to update the
linker scripts too - and running out of time this weekend so that
will be later.

Sam
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/