Re: [PATCH 1/5] lguest host feedback tidyups

From: Al Viro
Date: Sun May 13 2007 - 14:48:07 EST


On Sun, May 13, 2007 at 02:07:25PM +1000, Rusty Russell wrote:
> Most importantly, I now realize that Christoph's incorrect ranting
> about lgread_u32 et al was in fact a subtle ploy to make me diagnose
> the real issue: sparse 0.3 complains about casting a __user pointer
> to/from u32, but not an "unsigned long". They are (currently)
> equivalent for lguest, but this is a much better solution than __force.

The real fix would be to declare it with u32 __user * as argument and deal
with callers.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/