Re: [patch 3/3] clockevents: Fix resume logic - updated version

From: Andrew Morton
Date: Sun May 13 2007 - 18:36:38 EST


On Sun, 13 May 2007 22:07:39 +0200 Ingo Molnar <mingo@xxxxxxx> wrote:

>
> * Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> wrote:
>
> > Yeah, I expect quite a few people will start seeing that. iirc it was
> > triggered by a couple of changes: a local_irq_save/local_irq_restore
> > in sched_clock() and a change Jeremy made to the softlockup detector.
>
> hm, i specifically asked to not do local_irq_save/restore in
> sched_clock(). It's the _scheduler_ clock and it very absolutely
> positively needs no flags save/restore.
>

It got taken out again.

It doesn't matter though: a local_irq_save/restore in some callee shouldn't
cause the locking API tests to break. And they're apparently now breaking
without that local_irq_save/restore in there anyway.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/