Re: [PATCH] mm: swap prefetch more improvements

[Andrew Morton]

On Mon, 14 May 2007 10:50:54 +1000
Con Kolivas <kernel@xxxxxxxxxxx> wrote:

> akpm, please queue on top of "mm: swap prefetch improvements"
> 
> ---
> Failed radix_tree_insert wasn't being handled leaving stale kmem.
> 
> The list should be iterated over in the reverse order when prefetching.
> 
> Make the yield within kprefetchd stronger through the use of cond_resched.

hm.

> 
> -		might_sleep();
> -		if (!prefetch_suitable())
> +		/* Yield to anything else running */
> +		if (cond_resched() || !prefetch_suitable())
>  			goto out_unlocked;

So if cond_resched() happened to schedule away, we terminate this
swap-tricking attempt.  It's not possible to determine the reasons for this
from the code or from the changelog (==bad).

How come?

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/