Re: [PATCH] pcmcia: ppc64 needs 64-bit ioaddr_t

From: Benjamin Herrenschmidt
Date: Mon May 14 2007 - 18:48:54 EST


On Mon, 2007-05-14 at 15:08 -0700, Andrew Morton wrote:
>
> Well that's some pretty sad code you've found there. The kernel
> surely has
> some appropriate type to use here without us having to invent a new
> one.
> But I suspect if we were to rationalise things in there it will get
> messy.

There is more sad stuff involved with drivers assuming IO ports fit in
int. A proper fix for 2.6.23 will be the rework of PIO allocation I'm
doing. A temporary fix for 2.6.22 would be for Olof to use
reserve_phb_iospace() to make sure his PIO gets in the low 31 bits. We
need to add a spinlock to it though.

Ben.


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/