Re: [PATCH] LogFS take three

[Roland Dreier]

There are rather a lot of of FIXME comments, including scary stuff like

 > +	/*
 > +	 * FIXME: this cannot be right but it does "fix" a bug of i_count
 > +	 * dropping too low.  Needs more thought.
 > +	 */
 > +	atomic_inc(&old_dentry->d_inode->i_count);

and

 > +int __logfs_write_inode(struct inode *inode)
 > +{
 > +	/*
 > +	 * FIXME: Those two inodes are 512 bytes in total.  Not good to
 > +	 * have on the stack.  Possibly the best solution would be to bite
 > +	 * the bullet and do another format change before release and
 > +	 * shrink the inodes.
 > +	 */
 > +	struct logfs_disk_inode old, new;

are you going to change the format?  or fix this some other way?

I think a sweep through the code searching for FIXME and at least
rewriting all such comments to look like stuff that can be deferred
would be warranted ;)

 - R.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/