Re: [PATCH 1/3] hexdump: more output formatting

[Randy Dunlap]

Jesper Juhl wrote:
> On 30/05/07, Randy Dunlap <randy.dunlap@xxxxxxxxxx> wrote:
> > From: Randy Dunlap <randy.dunlap@xxxxxxxxxx>
>
> Some friendly nitpicking below :-)
>
> > Add a prefix string parameter.  Callers are responsible for any
> > string length/alignment that they want to see in the output.  I.e.,
> > callers should pad strings to achieve alignment if they want that.
> >
> > Add rowsize parameter.  This is the number of raw data bytes
> > to be printed per line.  Must be 16 or 32.
> >
> > Add a group_size parameter.  This allows callers to dump values
>
> One is called "rowsize" the other "group_size". How about consistent
> naming; either "row_size" and "group_size" or "rowsize" and
> "groupsize" ?

Done.  but please don't add that to CodingStyle.

> > as 1-byte, 2-byte, 4-byte, or 8-byte numbers.  Default is
> > 1-byte numbers.  If the total length is not an even multiple
> > of group_size, 1-byte numbers are printed.

--
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/