Re: [PATCH 4/5] serial: convert early_uart to earlycon for 8250

[Bjorn Helgaas]

On Wednesday 30 May 2007 10:48:59 pm Andrew Morton wrote:
> On Wed, 30 May 2007 21:36:41 -0700 "Yinghai Lu" <yhlu.kernel@xxxxxxxxx> wrote:
> 
> > On 5/30/07, Yinghai Lu <yhlu.kernel@xxxxxxxxx> wrote:
> > > On 5/30/07, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> wrote:
> > > > On Tue, 29 May 2007 18:43:59 -0700 Yinghai Lu <Yinghai.Lu@xxxxxxx> wrote:
> > > >
> > > > > [PATCH 4/5] serial: convert early_uart to earlycon for 8250
> > > >
> > > > drivers/serial/8250_early.c: In function 'parse_options':
> > > > drivers/serial/8250_early.c:143: error: 'FIX_EARLYCON_MEM_BASE' undeclared (first use in this function)
> > > > drivers/serial/8250_early.c:143: error: (Each undeclared identifier is reported only once
> > > >
> > > > That was with http://userweb.kernel.org/~akpm/config-sony.txt, but this is
> > > > going to break a whole pile of architectures (alpha, powerpc, others).
> > >
> > > alpha, powerpc, others may need sth like ia64, if they do not support fixmap.
> > 
> > or create dummy fixmap.h that doesn't support fixmap.
> 
> You could require that the architecture implement some specific function
> for mapping the early-uart.

We could, but we already have bt_ioremap, dmi_ioremap, and early_ioremap.
Do we really want to proliferate more flavors of "early ioremap"?  I'd
rather consolidate the ones we already have.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/