Re: [RFC] Documentation/CodingStyle: Add rules for goto labels

[Jeremy Fitzhardinge]

H. Peter Anvin wrote:
> goto labels are scoped in one sense: they are only reachable from inside
> the block they are defined in, so I would disagree with this statement.
>   

Erm, no I think you're wrong there (or we're talking at cross
purposes).  They're visible to the whole function they're defined in,
regardless of what block scope happens to be current at the time.  You
need to use the gcc "__label__" extension to make a locally-scoped
label.  Otherwise this wouldn't work:

	if (a_failed)
		goto cleanup;
	[...]
	if (b_failed) {
cleanup:
		cleanup();
	}


    J
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/