Re: [PATCH] support larger cifs network reads

From: Christoph Hellwig
Date: Tue Jun 05 2007 - 05:30:33 EST


On Thu, May 31, 2007 at 06:08:23PM -0500, Steve French wrote:
> With Samba 3.0.26pre it is now possible for a cifs client (one which
> supports the newest Unix/Posix cifs extensions) to request up to
> almost 8MB at a time on a cifs read request.
>
> A patch for the cifs client to support larger reads follows. In this
> patch, using very large reads is not the default behavior, since it
> would require larger buffer allocations for the large cifs request
> buffers, but in the future when cifs can demultiplex reads to a page
> list in the cifs_demultiplex_thread (without having to copy to a large
> temporary buffer) this will be even more useful.

Increasing this now doesn't make any sense - slab won't be able to
create a 8MB cache on most architectures, and even if it could the
wasted memory would be enormous. Once you actually support
scatter/gather allocations an increase is fine.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/