Re: lguest rebroken in 2.6.22-rc3-mm1

[Andi Kleen]

> But TSC is a "required feature", so "cpu_has_tsc" is always true.

Hmm? It isn't. What makes you think so?

cpufeature.h:
#define cpu_has_tsc             boot_cpu_has(X86_FEATURE_TSC)

% grep -i tsc include/asm-i386/required-features.h
% 

> How about this patch:
> ===
> Don't try to disable the TSC: it's a required feature under modern
> configurations, so just mark the sched clock unstable which has the
> same effect.

No, using the cpuid bit is the correct way. Or better fix lguest to support
TSC properly. You cannot stay forever in the keep-it-over-simple Minix trap anyways.

-Andi

 
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/