Re: [PATCH] Re: Linux v2.6.22-rc3

From: Jeff Garzik
Date: Fri Jun 08 2007 - 10:31:50 EST


On Fri, Jun 08, 2007 at 05:02:24PM +0900, Tejun Heo wrote:
> I don't think the first one is probable considering BSY is supposed to
> set when SRST is received. This is pretty fundamental in the protocol
> and necessary for the device to work properly as master, so I think this
> is one of few things we can rely upon.

See a URL I posted earlier in this thread. With dumb ATAPI devices we
actually have to wait a bit for BSY to be asserted. Not only at reset,
but also for every command.


> How about limiting nsect/lbal wait duration? Say, 100ms or 500ms? That
> can somewhat ease our paranoia and should show acceptable behavior for
> braindead devices too.

That's quite reasonable.

Jeff



P.S. We can probably reduce the msleep(150) sprinkled about the code to
msleep(100), for the dumb-ATAPI-device wait.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/