Re: [PATCH] update checkpatch.pl to version 0.03

From: Jesper Juhl
Date: Fri Jun 08 2007 - 10:34:23 EST

Next message: koan: "RE: [patch 29/32] NET: Fix race condition about network device name allocation."
Previous message: Thomas Gleixner: "[patch] lock debugging: loop nicer in mark_rt_mutex_waiters"
In reply to: Adrian Bunk: "Re: [PATCH] update checkpatch.pl to version 0.03"
Next in thread: Adrian Bunk: "Re: [PATCH] update checkpatch.pl to version 0.03"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

On 08/06/07, Adrian Bunk <bunk@xxxxxxxxx> wrote:
[snip]

It's not only about MODULE_AUTHOR, if you consider it rude to limit
people's names to ASCII, then don't forget that we have printk's like
Linux agpgart interface v0.102 (c) Dave Jones

What happens if the maintainer changes and it's now
Linux agpgart interface v0.103 (c) Dave Ønes

Does the console handle it correctly during boot?
Can all tools that process the syslog cope with it?

Perhaps the answer is in both cases "yes", but it's a completely
untested area.

We really must have all bugs shaken out and all users using fixed tools
_before_ we can start outputting UTF-8 - limiting people's names to
ASCII in not ideal, but IMHO causing breakages for users is a much
bigger problem.

I haven't looked at it in depth yet, but it would seem we already have
a few files that need to be looked at with this in mind. Looks like
it's not exactely a new problem (although all the following could be
in comments of course)...

$ find ./ -name "*.[ch]" | xargs file | grep -i utf
./arch/arm/mach-pxa/leds-trizeps4.c: UTF-8
Unicode C program text
./arch/arm/mach-pxa/trizeps4.c: UTF-8
Unicode C program text
./arch/powerpc/platforms/cell/spufs/file.c: UTF-8
Unicode C program text
./drivers/acpi/asus_acpi.c: UTF-8
Unicode C program text
./drivers/char/drm/r128_drv.h: UTF-8
Unicode C program text
./drivers/char/drm/radeon_irq.c: UTF-8
Unicode C program text
./drivers/char/drm/drm_drawable.c: UTF-8
Unicode C program text
./drivers/char/drm/drm_pci.c: UTF-8
Unicode C program text
./drivers/char/drm/drm_core.h: UTF-8
Unicode C program text
./drivers/char/hw_random/omap-rng.c: UTF-8
Unicode C program text
./drivers/char/esp.c: UTF-8
Unicode C program text
./drivers/char/watchdog/iTCO_vendor_support.c: UTF-8
Unicode C program text
./drivers/i2c/busses/i2c-iop3xx.c: UTF-8
Unicode C program text
./drivers/infiniband/core/multicast.c: UTF-8
Unicode C program text
./drivers/infiniband/core/sa.h: UTF-8
Unicode C program text
./drivers/infiniband/core/sa_query.c: UTF-8
Unicode C program text
./drivers/mtd/chips/cfi_cmdset_0001.c: UTF-8
Unicode C program text
./drivers/mtd/chips/cfi_probe.c: UTF-8
Unicode C program text
./drivers/mtd/devices/block2mtd.c: UTF-8
Unicode C program text
./drivers/mtd/devices/phram.c: UTF-8
Unicode English text
./drivers/mtd/maps/cfi_flagadm.c: UTF-8
Unicode C program text
./drivers/mtd/maps/dbox2-flash.c: UTF-8
Unicode C program text
./drivers/mtd/maps/mtx-1_flash.c: UTF-8
Unicode C program text
./drivers/mtd/nand/ts7250.c: UTF-8
Unicode C program text
./drivers/mtd/nand/cafe_nand.c: UTF-8
Unicode C program text
./drivers/mtd/nand/cmx270_nand.c: UTF-8
Unicode C program text
./drivers/mtd/nand/cs553x_nand.c: UTF-8
Unicode C program text
./drivers/mtd/nand/edb7312.c: UTF-8
Unicode C program text
./drivers/mtd/nand/h1910.c: UTF-8
Unicode C program text
./drivers/mtd/mtdsuper.c: UTF-8
Unicode C program text
./drivers/mtd/ubi/build.c: UTF-8
Unicode C program text
./drivers/mtd/ubi/cdev.c: UTF-8
Unicode C program text
./drivers/mtd/ubi/debug.c: UTF-8
Unicode C program text
./drivers/mtd/ubi/debug.h: UTF-8
Unicode C program text
./drivers/mtd/ubi/gluebi.c: UTF-8
Unicode C program text
./drivers/mtd/ubi/io.c: UTF-8
Unicode C program text
./drivers/mtd/ubi/kapi.c: UTF-8
Unicode C program text
./drivers/mtd/ubi/misc.c: UTF-8
Unicode C program text
./drivers/mtd/ubi/scan.c: UTF-8
Unicode C program text
./drivers/mtd/ubi/scan.h: UTF-8
Unicode C program text
./drivers/mtd/ubi/ubi.h: UTF-8
Unicode C program text
./drivers/mtd/ubi/upd.c: UTF-8
Unicode C program text
./drivers/mtd/ubi/vmt.c: UTF-8
Unicode C program text
./drivers/mtd/ubi/vtbl.c: UTF-8
Unicode C program text
./drivers/mtd/ubi/wl.c: UTF-8
Unicode C program text
./drivers/mtd/ubi/eba.c: UTF-8
Unicode C program text
./drivers/net/irda/toim3232-sir.c: UTF-8
Unicode English text
./drivers/net/irda/kingsun-sir.c: UTF-8
Unicode Pascal program text
./drivers/net/atl1/atl1_hw.h: UTF-8
Unicode C program text
./drivers/scsi/atari_NCR5380.c:
UTF-8 Unicode C program text
./drivers/scsi/jazz_esp.c:
UTF-8 Unicode C program text
./drivers/usb/misc/iowarrior.c:
UTF-8 Unicode C program text
./drivers/usb/misc/auerswald.c:
UTF-8 Unicode C program text
./drivers/video/atafb_iplan2p2.c:
UTF-8 Unicode C program text
./drivers/video/atafb_iplan2p4.c:
UTF-8 Unicode C program text
./drivers/video/atafb_iplan2p8.c:
UTF-8 Unicode C program text
./fs/afs/afs_vl.h:
UTF-8 Unicode C program text
./fs/jffs2/acl.c:
UTF-8 Unicode C program text
./fs/jffs2/acl.h:
UTF-8 Unicode C program text
./fs/jffs2/background.c:
UTF-8 Unicode C program text
./fs/jffs2/build.c:
UTF-8 Unicode C program text
./fs/jffs2/compr.c:
UTF-8 Unicode C program text
./fs/jffs2/compr.h:
UTF-8 Unicode C program text
./fs/jffs2/compr_rtime.c:
UTF-8 Unicode C program text
./fs/jffs2/compr_rubin.c:
UTF-8 Unicode C program text
./fs/jffs2/compr_zlib.c:
UTF-8 Unicode C program text
./fs/jffs2/debug.c:
UTF-8 Unicode C program text
./fs/jffs2/debug.h:
UTF-8 Unicode C program text
./fs/jffs2/dir.c:
UTF-8 Unicode C program text
./fs/jffs2/erase.c:
UTF-8 Unicode C program text
./fs/jffs2/file.c:
UTF-8 Unicode C program text
./fs/jffs2/fs.c:
UTF-8 Unicode C program text
./fs/jffs2/gc.c:
UTF-8 Unicode C program text
./fs/jffs2/ioctl.c:
UTF-8 Unicode C program text
./fs/jffs2/jffs2_fs_i.h:
UTF-8 Unicode C program text
./fs/jffs2/malloc.c:
UTF-8 Unicode C program text
./fs/jffs2/nodelist.c:
UTF-8 Unicode C program text
./fs/jffs2/nodelist.h:
UTF-8 Unicode C program text
./fs/jffs2/os-linux.h:
UTF-8 Unicode C program text
./fs/jffs2/read.c:
UTF-8 Unicode C program text
./fs/jffs2/security.c:
UTF-8 Unicode C program text
./fs/jffs2/summary.c:
UTF-8 Unicode C program text
./fs/jffs2/summary.h:
UTF-8 Unicode C program text
./fs/jffs2/symlink.c:
UTF-8 Unicode C program text
./fs/jffs2/wbuf.c:
UTF-8 Unicode C program text
./fs/jffs2/write.c:
UTF-8 Unicode C program text
./fs/jffs2/xattr.h:
UTF-8 Unicode C program text
./fs/jffs2/xattr_trusted.c:
UTF-8 Unicode C program text
./fs/jffs2/xattr_user.c:
UTF-8 Unicode C program text
./fs/jffs2/readinode.c:
UTF-8 Unicode C program text
./fs/jffs2/super.c:
UTF-8 Unicode C program text
./fs/jffs2/jffs2_fs_sb.h:
UTF-8 Unicode C program text
./fs/jffs2/nodemgmt.c:
UTF-8 Unicode C program text
./fs/jffs2/scan.c:
UTF-8 Unicode C program text
./fs/jffs2/writev.c:
UTF-8 Unicode C program text
./fs/jffs2/xattr.c:
UTF-8 Unicode C program text
./fs/nls/nls_utf8.c:
ASCII C program text
./include/asm-arm/arch-aaec2000/aaec2000.h:
UTF-8 Unicode C program text
./include/asm-arm/arch-integrator/platform.h:
UTF-8 Unicode C program text
./include/asm-arm/arch-omap/board.h:
UTF-8 Unicode C program text
./include/asm-arm/arch-omap/dma.h:
UTF-8 Unicode C program text
./include/asm-arm/arch-omap/gpio.h:
UTF-8 Unicode C program text
./include/asm-arm/arch-pxa/trizeps4.h:
UTF-8 Unicode C program text
./include/asm-m68k/atariints.h: UTF-8
Unicode C program text
./include/asm-m68k/atarihw.h: UTF-8
Unicode C program text
./include/asm-ppc/hydra.h: UTF-8
Unicode C program text
./include/linux/i2c-algo-bit.h: UTF-8
Unicode C program text
./include/linux/i2c-algo-pcf.h: UTF-8
Unicode C program text
./include/linux/i2c.h: UTF-8
Unicode C program text
./include/linux/irda.h: UTF-8
Unicode Pascal program text
./include/linux/meye.h: UTF-8
Unicode C program text
./include/linux/mtd/super.h: UTF-8
Unicode C program text
./include/linux/mtd/mtd.h: UTF-8
Unicode C program text
./include/linux/mtd/ubi.h: UTF-8
Unicode C program text
./include/linux/sonypi.h: UTF-8
Unicode C program text
./include/mtd/ubi-header.h: UTF-8
Unicode C program text
./include/mtd/ubi-user.h: UTF-8
Unicode C program text
./include/net/irda/irda.h: UTF-8
Unicode Pascal program text
./include/net/irda/iriap.h: UTF-8
Unicode Pascal program text
./include/net/irda/iriap_event.h: UTF-8
Unicode Pascal program text
./include/net/irda/irias_object.h: UTF-8
Unicode Pascal program text
./include/net/irda/irlan_client.h: UTF-8
Unicode Pascal program text
./include/net/irda/irlan_common.h: UTF-8
Unicode Pascal program text
./include/net/irda/irlan_eth.h: UTF-8
Unicode Pascal program text
./include/net/irda/irlan_event.h: UTF-8
Unicode Pascal program text
./include/net/irda/irlan_filter.h: UTF-8
Unicode Pascal program text
./include/net/irda/irlan_provider.h: UTF-8
Unicode Pascal program text
./include/net/irda/irlap.h: UTF-8
Unicode Pascal program text
./include/net/irda/irlmp.h: UTF-8
Unicode Pascal program text
./include/net/irda/irlmp_event.h: UTF-8
Unicode Pascal program text
./include/net/irda/irlmp_frame.h: UTF-8
Unicode Pascal program text
./include/net/irda/irmod.h: UTF-8
Unicode Pascal program text
./include/net/irda/irqueue.h: UTF-8
Unicode English text
./include/net/irda/irttp.h: UTF-8
Unicode Pascal program text
./include/net/irda/parameters.h: UTF-8
Unicode Pascal program text
./include/net/irda/timer.h: UTF-8
Unicode Pascal program text
./include/net/irda/wrapper.h: UTF-8
Unicode Pascal program text
./include/net/irda/af_irda.h: UTF-8
Unicode Pascal program text
./kernel/sys.c: UTF-8 Unicode
C program text
./sound/drivers/mts64.c: UTF-8 Unicode
C program text
./sound/oss/es1371.c: UTF-8 Unicode
C program text
./sound/oss/pas2_pcm.c: UTF-8 Unicode
C program text
./sound/oss/trident.c: UTF-8 Unicode
C program text
./sound/pci/ice1712/prodigy192.c: UTF-8 Unicode
C program text
./sound/pci/mixart/mixart.c: UTF-8 Unicode
C program text

--
Jesper Juhl <jesper.juhl@xxxxxxxxx>
Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please http://www.expita.com/nomime.html
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Next message: koan: "RE: [patch 29/32] NET: Fix race condition about network device name allocation."
Previous message: Thomas Gleixner: "[patch] lock debugging: loop nicer in mark_rt_mutex_waiters"
In reply to: Adrian Bunk: "Re: [PATCH] update checkpatch.pl to version 0.03"
Next in thread: Adrian Bunk: "Re: [PATCH] update checkpatch.pl to version 0.03"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]