Re: [PATCH] Include <asm/termbits.h> from <linux/tty_driver.h>.

[Robert P. J. Day]

On Fri, 8 Jun 2007, Alan Cox wrote:

> On Fri, 8 Jun 2007 09:29:12 -0400 (EDT)
> "Robert P. J. Day" <rpjday@xxxxxxxxxxxxxx> wrote:
>
> > The header file <linux/tty_driver.h> should include
> > <asm/termbits.h> to pick up the definition of "struct ktermios";
> > otherwise, you run the risk of seeing:
>
> Risk - which compile combinations does it actually show up with and
> is it not better to fix the C file in question not grow the horribly
> tangled include deps further

i don't see how fixing the C file solves this issue.  the header file
<linux/tty_driver.h> clearly refers to "struct ktermios", for which it
won't have a definition unless it includes <asm/termbits.h>.

you can hack a solution by explicitly including the latter first, of
course, but i don't see how that constitutes a proper fix.  or am i
misreading something here?

rday

p.s.  this isn't just theoretical -- this bit me this morning as i was
writing a simple module to flash the keyboard LEDs, just for the
entertainment value.

rday
-- 
========================================================================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry
Waterloo, Ontario, CANADA

http://fsdev.net/wiki/index.php?title=Main_Page
========================================================================
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/