Re: API changes / 2.6.21 sysctl changes

From: Alexey Dobriyan
Date: Mon Jun 11 2007 - 12:35:52 EST


On Mon, Jun 11, 2007 at 05:59:45PM +0200, Bernd Schubert wrote:
> On Monday 11 June 2007 17:46:27 Alexey Dobriyan wrote:
> > On Mon, Jun 11, 2007 at 03:13:12PM +0200, Bernd Schubert wrote:
> > > in 2.6.21 register_sysctl_table(), struct ctl_table and probably
> > > something else did change. Unfortunately so far I didn't figure out the
> > > "something else".
> >
> > Do you have a problem porting your sysctls to newer kernels?
>
> A little bit, yes. Well, I got it working, but I don't understand why I had to
> do that whay.
>
> I'm porting lustre to newer kernel versions and up to 2.6.20 the procfs/sysctl
> logic was
>
> 1.) register_sysctl_table() -> creates /proc/sys/lnet
>
> 2.) create_proc_entry() -> add additional files in /proc/sys/lnet

Glue all your ctl_table's in tree and register it with one call. See how
XFS does this: fs/xfs/linux-2.6/xfs_sysctl.c

> With 2.6.21 creating additional entries in /proc/sys/lnet fails and I have to
> first call "proc_mkdir("sys/lnet", NULL)". I did this proc_mkdir() call even
> before the register_sysctl_table() call, hoping that its correct.
>
> My guess is that register_sysctl_table() doesn't create /proc/sys/lnet
> anymore, but I have now idea why. Either I did something wrong or its
> intended.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/