RE: [PATCH 1/5] Add the explanation and sample of RapidIO DTS sector to the document of booting-without-of.txt file.

[Zhang Wei-r63237]

Hi, Segher, 

> -----Original Message-----
> Subject: Re: [PATCH 1/5] Add the explanation and sample of 
> RapidIO DTS sector to the document of booting-without-of.txt file.
> 
> > +   k) RapidIO
> > +
> > +   Required properties:
> > +
> > +    - device_type : Should be "rapidio"
> 
> There is no OF binding, so no.

So, we need to define it.

> 
> > +    - compatible : Should be "fsl,rapidio-v0.0" or 
> "fsl,rapidio-v1.0"
> > +      and so on. The version number is got from IP Block Revision
> > +      Register of RapidIO controller.
> 
> It's better to use real device names, just like everyone
> else.

Some silicons of Freescale processor are the same RapidIO controller,
such as mpc8540/mpc8560 are the same (v0.0), mpc8548/mpc8641 are the
same (v1.0). For v1.0 RapidIO controller, should we use mpc8548 or
mpc8641? Those will make people confused. Using IP Block Revision is a
clear choice.

> 
> > +    - #address-cells : Address representation for 
> "rapidio" devices.
> > +      This field represents the number of cells needed to represent
> > +      the RapidIO address of the registers.  For 
> supporting more than
> > +      36-bits RapidIO address, this field should be <2>.
> 
> More than 32 bit?

Yes, RapidIO bus address width is 34 bits.

> 
> > +    - interrupt-parent : the phandle for the interrupt 
> controller that
> > +      services interrupts for this device.
> 
> Not required, depends on the interrupt tree of the system.
> 
> > +    - interrupts : <a b> where a is the interrupt number and b is a
> > +      field that represents an encoding of the sense and level
> > +      information for the interrupt.
> 
> No.  The format of an "interrupts" entry is defined by
> the interrupt domain this device sits in, not by the
> device itself.
> 
Do you misunderstand the meaning of 'interrupts'? These interrupts is
issued from the RapidIO controller to the pic controller for tx, rx,
err, doorbell and message.


> > For this sector, interrupts order should be
> > +      <err_irq bell_outb_irq bell_inb_irq msg1_tx_irq msg1_rx_irq
> > +      msg2_tx_irq msg2_rx_irq ... msgN_tx_irq msgN_rx_irq>.
> 
> That's to be defined in the binding for your specific device,
> not in a more generic rapidio binding.

These description is just for compatible="fsl,rapidio-v*.*" rapidio
controller.

> 
> > +		#address-cells = <2>;
> 
> You want a #size-cells as well.
> 

The size is not used in this sector, so no defined.

Thanks!
Wei.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/