Re: w1_therm_read_bin: suspicious usage of flush_signals()

[Evgeniy Polyakov]

On Thu, Jun 14, 2007 at 09:24:39PM +0400, Oleg Nesterov (oleg@xxxxxxxxxx) wrote:
> drivers/w1/slaves/w1_therm.c:w1_therm_read_bin()
> 
> 	while (tm) {
> 		tm = msleep_interruptible(tm);
> 		if (signal_pending(current))
> 			flush_signals(current);
> 	}
> 
> current is user-space task, yes?
> 
> this looks just wrong, could you please explain?

Hi Oleg.

Well, it can be uninterruptible sleep, but why?
It is not allowed to return to userspace until transaction is completed,
so having uninterruptible sleep will result in exactly same lost of
signals.

> Oleg.

-- 
	Evgeniy Polyakov
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/