Re: [PATCH] atmel_lcdfb: Fix wrong line_length calculation
From: Nicolas Ferre
Date: Fri Jun 15 2007 - 04:58:00 EST
Haavard Skinnemoen :
As Jan Altenberg pointed out, line_length will always be 0 if
bits_per_pixel < 8. Fix this and also make sure that we round up to
the nearest byte.
Signed-off-by: Haavard Skinnemoen <hskinnemoen@xxxxxxxxx>
---
I haven't tested this with any real program that uses the frame buffer,
but fbset seems to report sane values for line_length:
Thank you Haavard.
I have a bigger patch for all the support for STN display (tested with
mono STN display). It is based on the work from Jan Altenberg.
This bigger patch includes your modifications.
I send it right now. As a separate message.
Haavard, can you check if the compute_hozval()
function is ok on avr32 (I have reviewed with the at32ap7000 and hope
that it is ok) ?
Regards,
--
Nicolas Ferre
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/