Re: [PATCH 2.6.21] cramfs: add cramfs Linear XIP

From: Carsten Otte
Date: Fri Jun 15 2007 - 05:22:38 EST


Jared Hulbert wrote:
An alternative approach, which does not need to have struct page at
hand, would be to use the nopfn vm operations struct. That one would
have to rely on get_xip_pfn.
Of course! Okay now I'm begining to understand.
Sorry, but I think I was educated yesterday that ->fault() (only in -mm) is where we'd be heading. Nopfn is deprecated. But conceptually, this does'nt change things.

The current path would then be deprecated.
Why? Wouldn't both paths be valid options?
The new path via fault works in both cases with and without struct page behind. No need to keep the old one as far as I see.

If you're interrested in using the later for xip without
struct page, I would volounteer to go ahead and implement this?
I'm very interested in this.
Good. Let me see if I can come up with a patch on this.

I'm not opposed to using struct page, but I'm confused as to how to
start that. As I understand it, which is not well, defined a
CONFIG_DISCONTIGMEM region to cover the Flash memory would add that to
my pool of RAM. That would be 'bad', right? I don't see how to
create the page structs and set this memory aside as different.
I fear I am not the right person to answer that question. In the good old days before discontigmem/sparse mem/vmem map where invented we used to have a hack for that in arch/. Heiko then decided my hack is a mess and came up with a good solution to the problem.

so long,
Carsten
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/