Re: [PATCH, 3rd try] make disable_console_suspend runtime configurable

[Pavel Machek]

On Fri 2007-06-15 00:20:28, Rafael J. Wysocki wrote:
> On Thursday, 14 June 2007 15:59, Frank Seidel wrote:
> > From: Stefan Seyfried <seife@xxxxxxx>
> > 
> > I hate having to recompile the kernel, just to be able to debug suspend.
> > Remove CONFIG_DISABLE_CONSOLE_SUSPEND, replace it by a tunable in
> > /sys/power/disable_console_suspend.
> > 
> > 
> > Signed-off-by: Stefan Seyfried <seife@xxxxxxx>
> > Signed-off-by: Frank Seidel <fseidel@xxxxxxx>
> > ---
> > Third try, renamed sysfs interface to console_suspend 
> > reporting and expecting either "enabled" or "disabled"
> 
> Thanks a lot for redoing it.
> 
> I have no objections.  Pavel?

I still think that patch is bad. I should have screamed when
CONFIG_DISABLE_CONSOLE_SUSPEND went into kernel. That beast should
_not_ be configurable, it should just do the right thing.

But I realized that too late. And this only makes it works, making
that mistake part of user-kernel interface.

Sorry for not screaming when CONFIG_DISABLE_CONSOLE_SUSPEND went in,
but please lets solve this correctly....

Like every console says if it needs to  be disabled during suspend,
and if at least one active console says so, we disable. Nothing to
configure, we just do the right thing. And it should not be that much
work, either.
								Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/