Re: [patch] use __asm__ and __volatile__ in i386/arm/s390 byteorder.h

[Mike Frysinger]

On Monday 18 June 2007, Christoph Hellwig wrote:
> On Mon, Jun 18, 2007 at 01:24:24AM +0200, Arnd Bergmann wrote:
> > On Monday 18 June 2007, Arjan van de Ven wrote:
> > > On Sun, 2007-06-17 at 18:33 -0400, Mike Frysinger wrote:
> > > > This changes asm() to __asm__() and volatile to __volatile__ so that
> > > > these headers can be used with gcc's -std=c99.
> > >
> > > hmm but the kernel doesn't use -std=c99...
> >
> > The byteorder headers are exported to user space through
> > include/asm-generic/Kbuild.asm, and they are used by a number
> > of other exported headers, so they should work with any
> > gcc flags that a user might want to use.
>
> No, they should not be exported and the headers using them
> should be fixed to not require this.  Userspace has it's own
> endianess handling already.

user applications arent pulling these things in themselves ... you have to 
also think of the cascading of header includes ... asm/byteorder.h gets 
pulled in by many other things

if we want to scrub the userspace headers so that asm/byteorder.h isnt even 
installed, that works for me as well, however i wouldnt discount the patch i 
proposed on this alone ... the headers are inconsistent between using asm and 
__asm__ and if anything, my patch makes them consistent
-mike

Attachment: signature.asc
Description: This is a digitally signed message part.