Re: [Intel IOMMU 06/10] Avoid memory allocation failures in dma mapapi calls

[Arjan van de Ven]

Christoph Lameter wrote:
> On Tue, 19 Jun 2007, Keshavamurthy, Anil S wrote:
>
>
> > So far in our test scenario, we were unable to create
> > any memory allocation failure inside dma map api calls.
>
> All these functions should have gfp_t flags passed to them.

why?

> Otherwise you are locked into the use of GFP_ATOMIC.

all callers pretty much are either in irq context or with spinlocks 
held. Good luck..... it's also called primarily from the PCI DMA API 
which doesn't take a gfp_t argument in the first place...

so I'm not seeing the point.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/