Re: 2.6.22-rc5 regression

[Dave Jones]

On Wed, Jun 20, 2007 at 01:37:16AM +0200, Carlo Wood wrote:

 > Personally I am convinced that the real problem is with
 > 8888985144db8f4cb7e56154b31bdf233d3550bf
 > 
 >     [AGPGART] intel_agp: fix device probe
 >     
 >     This patch trys to fix device probe in two cases. First we should
 >     correctly detect device if integrated graphics device is not enabled
 >     or exists, like an add-in card is plugged. Second on some type of intel
 >     GMCH, it might have multiple graphic chip models, like 945GME case, so
 >     we should be sure the detect works through the whole table.
 >     
 >     Signed-off-by: Wang Zhenyu <zhenyu.z.wang@xxxxxxxxx>
 >     Signed-off-by: Dave Jones <davej@xxxxxxxxxx>
 > 
 > 
 > The result of this patch is that the kernel starts to print
 > "agpgart: Detected an Intel 965G Chipset." again with the usual
 > disastrous results. Now, that doesn't mean that this patch is
 > wrong - but it explains why the problem returns after this patch.

Right, without this patch, probing was broken, so we never matched
an agp driver to the chipset.  The question remains though, why
the initialisation of the chip is so broken.

	Dave

-- 
http://www.codemonkey.org.uk
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/