Re: [i2c] [PATCH] I2C: TSL2550 support.

[Jean Delvare]

Hi Rodolfo,

On Tue, 19 Jun 2007 16:48:46 +0200, Rodolfo Giometti wrote:
> Please, note that I left LUX calculation untouched since on my data
> sheet I have only such cumputation example. :(
> 
> Hope it could be ok anyway...

Datasheets typically give you one way to process the data, that doesn't
mean this is the only way, nor the best in all situations. My proposal
was mathematically equivalent to your datasheet-based implementation,
and had a lower memory footprint.

Anyway, your way works too, so it's OK. I'll take your patch as is,
optimizations can always be applied later. I wish I could give a try to
your driver, but unfortunately I still didn't manage to get my TAOS
evaluation module to work under Linux :(

-- 
Jean Delvare
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/