Re: [PATCH for 2.6.22] [6/10] x86: Only make Macintosh driversdefault on Macs

[Will Schmidt]

On Thu, 2007-06-21 at 19:36 +0200, Olaf Hering wrote:
> On Wed, Jun 20, Andi Kleen wrote:
> 
> > 
> > It's already annoying that they appear on x86 now -- that's for the 3button
> > emulation needed on x86 macs -- but at least don't make them default.
> > 
> > Signed-off-by: Andi Kleen <ak@xxxxxxx>
> > 
> > ---
> >  drivers/macintosh/Kconfig |    2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > Index: linux/drivers/macintosh/Kconfig
> > ===================================================================
> > --- linux.orig/drivers/macintosh/Kconfig
> > +++ linux/drivers/macintosh/Kconfig
> > @@ -2,7 +2,7 @@
> >  menuconfig MACINTOSH_DRIVERS
> >  	bool "Macintosh device drivers"
> >  	depends on PPC || MAC || X86
> > -	default y
> > +	default y if MAC
> 
> This looks incorrect because my macdrivers were almost gone now when
> updating from 2.6.21 to 2.6.22. 
> A better one may be something like this, to not lose everything on a G5:
> 
>         depends on PPC_PMAC || MAC || X86
>         default y if (PPC_PMAC || MAC)
> 

I'll second that.  The obvious gotcha is that on a G5, the windfarm
drivers don't get automatically selected, thus the fans run at full
speed, and my office becomes a windtunnel. :-) 

-Will

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/