Re: [PATCH 7/12] acpi: fix another compile warning

From: Andrew Morton
Date: Fri Jun 22 2007 - 23:56:18 EST


> On Wed, 20 Jun 2007 11:25:48 -0700 Ravikiran G Thirumalai <kiran@xxxxxxxxxxxx> wrote:
> Paper over 'select' inadequacies.
>
> Signed-off-by: Ravikiran Thirumalai <kiran@xxxxxxxxxxxx>
>
> Index: linux-2.6.22-rc5/arch/x86_64/Kconfig
> ===================================================================
> --- linux-2.6.22-rc5.orig/arch/x86_64/Kconfig 2007-06-18 16:02:19.571323415 -0700
> +++ linux-2.6.22-rc5/arch/x86_64/Kconfig 2007-06-20 11:34:29.845354250 -0700
> @@ -366,6 +366,7 @@ config X86_64_ACPI_NUMA
> depends on NUMA
> select ACPI
> select PCI
> + select PM
> select ACPI_NUMA
> default y
> help

argh. (and not just argh-at-your-email-client).

I went through some hair-tearing a few months ago working out why it is so
damn hard to make CONFIG_PM go away and then I fixed it. And now you're
proposing a change which would reinstate the obnoxious old behaviour.

Is the "bug" which you're "fixing" here caused by the randconfig
inadequacies? Because randconfig is just busted and simply should auto-run
oldconfig.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/