Re: [patch 1/3] add the fsblock layer

[Andi Kleen]

Nick Piggin <npiggin@xxxxxxx> writes:


[haven't read everything, just commenting on something that caught my eye]

> +struct fsblock {
> +	atomic_t	count;
> +	union {
> +		struct {
> +			unsigned long	flags; /* XXX: flags could be int for better packing */

int is not supported by many architectures, but works on x86 at least.

Hmm, could define a macro DECLARE_ATOMIC_BITMAP(maxbit) that expands to the smallest
possible type for each architecture. And a couple of ugly casts for set_bit et.al.
but those could be also hidden in macros. Should be relatively easy to do.

-Andi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/