Re: [PATCH 2/2] [RESEND] PCI: Change all drivers to usepci_device->revision

[Alan Cox]

On Sun, 24 Jun 2007 20:19:29 -0700
Auke Kok <auke-jan.h.kok@xxxxxxxxx> wrote:

> Instead of all drivers reading pci config space to get the revision
> ID, they can now use the pci_device->revision member.
> 
> This exposes some issues where drivers where reading a word or a dword
> for the revision number, and adding useless error-handling around the
> read. Some drivers even just read it for no purpose of all.
> 
> In devices where the revision ID is being copied over and used in what
> appears to be the equivalent of hotpath, I have left the copy code
> and the cached copy as not to influence the driver's performance.
> 
> Compile tested with make all{yes,mod}config on x86_64 and i386.

Ack the drivers/ata part but please split this up per subsystem and send
the chunks to the subsystem maintainers.

Alan
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/