Re: [PATCH 2/5] piix: backport short cables support from ata_piix.c
From: Sergei Shtylyov
Date: Tue Jun 26 2007 - 14:28:53 EST
Bartlomiej Zolnierkiewicz wrote:
Backport short cables support from ata_piix.c.
This patch should allow UDMA > 2 modes on:
- Acer 5602WLMi
- Acer 3682WLMi
- Asus W5F
- Acer Aspire 2023WLMi
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@xxxxxxxxx>
Acked-by: Sergei Shtylyov <sshtylyov@xxxxxxxxxxxxx>
Minor nit here:
Index: b/drivers/ide/pci/piix.c
===================================================================
--- a/drivers/ide/pci/piix.c
+++ b/drivers/ide/pci/piix.c
@@ -394,12 +394,43 @@ static void piix_dma_clear_irq(ide_drive
[...]
static u8 __devinit piix_cable_detect(ide_hwif_t *hwif)
{
- struct pci_dev *dev = hwif->pci_dev;
+ struct pci_dev *pdev = hwif->pci_dev;
Unnecessary rename.
+ const struct ich_laptop *lap = &ich_laptop[0];
... and & and [0] are superfluous with arrays -- they behave like pointers
in expression.
MBR, Sergei
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/