Re: ZERO_PAGE() vs. loadable modules in Redhat 4.4 i386 kernels ...

[Casey Leedom]

--- Hugh Dickins <hugh@xxxxxxxxxxx> wrote:

> I can't speak for Red Hat 4.4; but in general, you should be passing the
> write flag to get_user_pages if you're going to modify the content of
> those pages, which will then allocate the hierarchy needed and break
> COW where necessary.

  yes, that would definitely be the case if I were doing a DMA read but in this
case I'm doing a DMA write.  I could force the kernel to instantiate zero'ed
pages for the entire range but that would significantly impact performance.

> If that doesn't suit you (e.g. it's supposed to
> be a readonly area in userspace), then you proably shouldn't be using
> get_user_pages at all, but letting userspace mmap your driver pages
> into its space instead.  Definitely don't play empty_zero_page games.

  Hhrrrmmm, I'm not sure I understand what you're saying here.  In our case the
user application just does a write() on a socket.  Our driver is doing a DMA
directly from user pages out to the interface.  We have fallback timeout code
if the DMA takes longer than a certain length of time where we mark the pages
that haven't yet been transfered as COW so we can return early to the user
application without violating Linux write() semantics.  It sounds like you're
advocating major changes to the application which wouldn't be useful.  My
appologies if I'm misinterpreting your comment.

Casey
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/