drivers/net/wireless/libertas/rx.c: use-after-free

From: Adrian Bunk
Date: Fri Jun 29 2007 - 15:51:07 EST


The Coverity checker spotted the following use-after-free of "skb" in
drivers/net/wireless/libertas/rx.c introduced by
commit 9012b28a407511fb355f6d2176a12d4653489672 (WTF did this commit
with the title "libertas: make debug configurable" add the
"skb->protocol = __constant_htons(0x0019);" line?):

<-- snip -->

...
static int process_rxed_802_11_packet(wlan_private * priv, struct sk_buff *skb)
{
...
libertas_upload_rx_packet(priv, skb);

ret = 0;

done:
skb->protocol = __constant_htons(0x0019); /* ETH_P_80211_RAW */
...

<-- snip -->


cu
Adrian

--

"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/