Re: [RFC][PATCH -mm] PM: Do not sync filesystems from within the freezer

[Rafael J. Wysocki]

On Friday, 6 July 2007 00:00, Pavel Machek wrote:
> Hi!
> 
> > From: Rafael J. Wysocki <rjw@xxxxxxx>
> > 
> > The syncing of filesystems from within the freezer is generally not needed.
> > Change freeze_processes() so that it doesn't execute sys_sync() and make the
> > suspend and hibernation code path sync filesystems independently of the freezer.
> 
> Yes, we can do that, but ... why?

I think that sync and the freezer are different things and shouldn't be mixed in
such a way as they are now.

> Does it actually fix FUSE?

It should prevent the freezer from deadlocking.

> Miklos claims sync is nop on FUSE...? 

In that case there shouldn't be any deadlock, but a freezer failure. :-)

Greetings,
Rafael


-- 
"Premature optimization is the root of all evil." - Donald Knuth
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/