Re: [PATCH] Some love to default profiler

From: Jesper Juhl
Date: Sun Jul 08 2007 - 14:53:17 EST


On 08/07/07, Adrian Bunk <bunk@xxxxxxxxx> wrote:
On Thu, Jul 05, 2007 at 01:50:27AM +0200, Jesper Juhl wrote:
> On 04/07/07, Alexey Dobriyan <adobriyan@xxxxxxxxx> wrote:
>> 1) Drop __KERNEL__ out of profile.h. It contains only internal kernel
>> stuff and
>> not in exported headers list
>
> Even if it's not in the list of exported headers, does it really hurt
> to retain that extra safeguard?
>...

Safeguard for what?

Well, for userspace code that tries to include the file. I know
nobody should, but somebody still might. At least that was my
thought when I made that comment.

And it has to be consistent, and current policy is to not have
#ifdef __KERNEL__'s in all not to userspace exported headers.

Ok, in that case it should go away.


--
Jesper Juhl <jesper.juhl@xxxxxxxxx>
Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please http://www.expita.com/nomime.html
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/