Re: [PATCH] Enable legacy support for serial ports when SERIAL_8250_PNP is disabled

[Bjorn Helgaas]

On Monday 09 July 2007 11:30:59 am Luca wrote:
> On 7/9/07, Bjorn Helgaas <bjorn.helgaas@xxxxxx> wrote:
> > On Saturday 07 July 2007 05:33:00 pm Luca Tettamanti wrote:
> > > your patch:
> > >
> > > commit 7e92b4fc345f5b6f57585fbe5ffdb0f24d7c9b26
> > > Author: Bjorn Helgaas <bjorn.helgaas@xxxxxx>
> > > Date:   Tue May 8 00:36:07 2007 -0700
> > >
> > >     x86, serial: convert legacy COM ports to platform devices
> > >
> > > disables probing using legacy code in favour of ACPI/PNP to avoid double
> > > discovery.
> > >
> > > However if SERIAL_8250_PNP is not enabled the user is left without
> > > serial ports (been there, done that - my kernel config suddenly wasn't
> > > working anymore). So:
> >
> > Yes, that's true.  Kconfig should automatically turn on SERIAL_8250_PNP
> > if PNP and SERIAL_8250 are selected, but it does give you a choice if
> > you have EMBEDDED set.  So I guess you must have this:
> >
> >   CONFIG_EMBEDDED=y
> >   CONFIG_PNP=y
> >   CONFIG_SERIAL_8250=y
> >   CONFIG_SERIAL_8250_PNP=n
> >
> > Why do you want PNP support, but not 8250_PNP support?
> 
> That's a good question :-) IIRC the serial PNP code used to mess up
> the mode of the port on my laptop, making it useless for debugging the
> boot. Bug was fixed long ago, but I didn't re-enabled that option.

It wouldn't surprise me if serial PNP can be tripped up by the
incomplete Linux PNP code or by buggy firmware.  If you find any
issues like that, I'll fix them.

> > If you turn off
> > PNP completely, you will have "pnp_platform_devices == 0", and the
> > existing code will do what you need.
> 
> Well for me it's a non-issue, I'm able to "work-around" it in many
> ways. My point is that a configuration that used to work and is still
> valid suddenly doesn't work anymore.

You're right about that, and it is a legitimate issue.  But given the
fact that (PNP && !SERIAL_8250_PNP) should be relatively unusual, my
opinion is that it's not worth extra ifdefs in legacy_serial.c.

If you have to use any workarounds like "legacy_serial.force", I think
that's a bug, and I'll fix it.

Bjorn
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/