Re: [PATCH 1/4] try parent numa_node at first before using default

From: Greg KH
Date: Mon Jul 09 2007 - 20:45:34 EST


On Tue, Jul 03, 2007 at 05:31:02PM -0700, Yinghai Lu wrote:
> [PATCH 1/4] try parent numa_node at first before using default
>
> Signed-off-by: Yinghai Lu <yinghai.lu@xxxxxxx>
>
> diff --git a/drivers/base/core.c b/drivers/base/core.c
> index dd40d78..c344d82 100644
> --- a/drivers/base/core.c
> +++ b/drivers/base/core.c
> @@ -547,6 +547,8 @@ static void klist_children_put(struct klist_node *n)
>
> void device_initialize(struct device *dev)
> {
> + int node;
> +
> kobj_set_kset_s(dev, devices_subsys);
> kobject_init(&dev->kobj);
> klist_init(&dev->klist_children, klist_children_get,
> @@ -557,7 +559,9 @@ void device_initialize(struct device *dev)
> spin_lock_init(&dev->devres_lock);
> INIT_LIST_HEAD(&dev->devres_head);
> device_init_wakeup(dev, 0);
> - set_dev_node(dev, -1);
> +
> + node = dev->parent ? dev_to_node(dev->parent) : -1;
> + set_dev_node(dev, node);
> }

What is this going to give us?

Doesn't it mean that all devices will end up on the same node?

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/