Re: sched: rename idle_type/SCHED_IDLE

[Jan Dittmer]

Linux Kernel Mailing List wrote:
> Gitweb:     http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=d15bcfdbe1818478891d714343f037cfe60875f0
> Commit:     d15bcfdbe1818478891d714343f037cfe60875f0
> Parent:     7dcca30a32aadb0520417521b0c44f42d09fe05c
> Author:     Ingo Molnar <mingo@xxxxxxx>
> AuthorDate: Mon Jul 9 18:51:57 2007 +0200
> Committer:  Ingo Molnar <mingo@xxxxxxx>
> CommitDate: Mon Jul 9 18:51:57 2007 +0200
> 
>     sched: rename idle_type/SCHED_IDLE
>     
>     enum idle_type (used by the load-balancer) clashes with the
>     SCHED_IDLE name that we want to introduce. 'CPU_IDLE' instead
>     of 'SCHED_IDLE' is more descriptive as well.

> --- a/include/linux/sched.h
> +++ b/include/linux/sched.h
> @@ -639,12 +639,11 @@ static inline int sched_info_on(void)
>  #endif
>  }
>  
> -enum idle_type
> -{
> -	SCHED_IDLE,
> -	NOT_IDLE,
> -	NEWLY_IDLE,
> -	MAX_IDLE_TYPES
> +enum cpu_idle_type {
> +	CPU_IDLE,
> +	CPU_NOT_IDLE,
> +	CPU_NEWLY_IDLE,
> +	CPU_MAX_IDLE_TYPES
>  };
>  
>  /*

This broke s390:

  GEN     /tmp/tmp.qnrRZ13800/out/s390/Makefile
  CHK     include/linux/version.h
  UPD     include/linux/version.h
  CHK     include/linux/utsrelease.h
  UPD     include/linux/utsrelease.h
  SYMLINK include/asm -> include/asm-s390
  CC      arch/s390/kernel/asm-offsets.s
In file included from
/tmp/tmp.qnrRZ13800/kernel/arch/s390/kernel/asm-offsets.c:7:
/tmp/tmp.qnrRZ13800/kernel/include/linux/sched.h:641: error: syntax
error before numeric constant
make[2]: *** [arch/s390/kernel/asm-offsets.s] Error 1
make[1]: *** [prepare0] Error 2
make: *** [_all] Error 2
  CLEAN   .tmp_versions


Jan
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/