Re: [patch] mm: recheck lock rlim after f_op->mmap() method

[Jes Sorensen]

Hugh Dickins wrote:
> On Mon, 9 Jul 2007, Dmitry Monakhov wrote:
>> Some device drivers can change vm_flags in their f_op->mmap
>> method. In order to be on the safe side we have to recheck
>> lock rlimit. Now we have to check lock rlimit from two places,
>> let's move this common code to helper functon.
>>
>> Signed-off-by: Dmitry Monakhov <dmonakhov@xxxxxxxxxx>
>> ---
>>  mm/mmap.c |   33 ++++++++++++++++++++++++++-------
>>  1 files changed, 26 insertions(+), 7 deletions(-)
> 
> Or would this simpler patch be the right one?  I suspect the
> mspec driver only says VM_LOCKED because of a deep-seated but
> irrational fear that its pages might fall into reclaim.
> 
> (I'd like to take out VM_RESERVED too, but that can always happen
> another, indefinitely postponed time; there are others of those.)

Hi Hugh,

My mind is rusty on this one, so I checked with Robin Holt and his
is too .... most likely mspec has it for legacy problems, if your
change shows up to cause new problems, we'll fix them when they appear.
So from our side, it's fine to go ahead with this patch.

Cheers,
Jes
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/