Re: [PATCH] UBI: cleanup usage of try_module_get
From: Artem Bityutskiy
Date: Wed Jul 11 2007 - 05:18:29 EST
On Wed, 2007-07-11 at 17:11 +0900, Fernando Luis VÃzquez Cao wrote:
> The use of try_module_get(THIS_MODULE) in ubi_get_device_info does not
> offer real protection against unexpected driver unloads, since we could
> be preempted before try_modules_get gets executed. It is the caller who
> should manipulate the refcounts. Besides, ubi_get_device_info is an
> exported symbol which guarantees protection when accessed through
> symbol_get.
Yeah, looks fair, committed to UBI git, thanks.
--
Best regards,
Artem Bityutskiy (ÐÐÑÑÑÐÐÐ ÐÑÑÑÐ)
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/