Re: [PATCH] serial: do not add port that is not initialized

[Bjorn Helgaas]

On Wednesday 11 July 2007 01:17:42 am Russell King wrote:
> On Tue, Jul 10, 2007 at 05:03:35PM -0700, Yinghai Lu wrote:
> > [PATCH] serial: do not add port that is not initialized
> > 
> > if the port is not initialized with correct iobase, and membase, we don't
> > need to add that port.
> > for x86, when pnpacpi is enabled, we will not get extra ttyS1/ttyS2/ttyS3 in
> > /sys/devices/platform/serial8250/tty
> > 
> > Sign-off-by: Yinghai Lu <yinghai.lu@xxxxxxx>
> 
> What if someone wants to run setserial on /dev/ttyS1 to set it's base
> address, irq and other parameters?  People still do this.

I agree that people still use setserial that way, and we shouldn't
make this change because it would break things.

But I also agree with Yinghai that these extra phantom devices are
just weird.  It would be a lot nicer if there were a way to say,
"please, Mr. Serial Driver, create me a new ttyS device with these
parameters."

But no, I'm not volunteering to do that.

Bjorn
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/