Re: [Patch] drivers/mtd/maps/tqm8xxl.c: Style cleanups
From: Josh Boyer
Date: Thu Jul 12 2007 - 12:12:18 EST
On Thu, 2007-07-12 at 23:01 +0800, WANG Cong wrote:
> Change C++ style comments into K&R's.
> Cut long lines into pieces.
>
> This patch is against 2.6.22.1, and can be also applied to
> the last -mm tree.
>
> Signed-off-by: WANG Cong <xiyou.wangcong@xxxxxxxxx>
>
> ---
>
> tqm8xxl.c | 41 +++++++++++++++++++++++++----------------
> 1 file changed, 25 insertions(+), 16 deletions(-)
>
> Index: linux-2.6.22.1/drivers/mtd/maps/tqm8xxl.c
> ===================================================================
> --- a/drivers/mtd/maps/tqm8xxl.c 2007-04-26 11:08:32.000000000 +0800
> +++ b/drivers/mtd/maps/tqm8xxl.c 2007-07-05 00:16:16.000000000 +0800
> @@ -38,7 +38,7 @@
> #define FLASH_SIZE 0x00800000
> #define FLASH_BANK_MAX 4
>
> -// trivial struct to describe partition information
> +/* trivial struct to describe partition information*/
Needs a space at the end.
> struct mtd_part_def
> {
> int nums;
> @@ -46,7 +46,7 @@
> struct mtd_partition* mtd_part;
> };
>
> -//static struct mtd_info *mymtd;
> +/*static struct mtd_info *mymtd;*/
Just delete this...
> static struct mtd_info* mtd_banks[FLASH_BANK_MAX];
> static struct map_info* map_banks[FLASH_BANK_MAX];
> static struct mtd_part_def part_banks[FLASH_BANK_MAX];
> @@ -106,7 +106,7 @@
> .name = "jffs",
> .offset = 0x00200000,
> .size = 0x00200000,
> - //.size = MTDPART_SIZ_FULL,
> + /*.size = MTDPART_SIZ_FULL,*/
Delete it...
> }
> };
> #endif
> @@ -121,10 +121,11 @@
> flash_addr = bd->bi_flashstart;
> flash_size = bd->bi_flashsize;
>
> - //request maximum flash size address space
> + /*request maximum flash size address space*/
Spaces needed (repeat for the rest of the ones that don't have spaces
either).
josh
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/