Re: lguest, Re: -mm merge plans for 2.6.23

[Rusty Russell]

On Thu, 2007-07-12 at 14:10 +0300, Avi Kivity wrote:
> Rusty Russell wrote:
> > Remove export of __put_task_struct, and usage in lguest
> >
> > lguest takes a reference count of tasks for two reasons.  The first is
> > bogus: the /dev/lguest close callback will be called before the task
> > is destroyed anyway, so no need to take a reference on open.
> >
> >   
> 
> What about
> 
>   Open /dev/lguest
>   transfer fd using SCM_RIGHTS (or clone()?)
>   close fd in original task
>   exit()
> 
> ?
> 
> My feeling is that if you want to be bound to a task, not a file, you 
> need to use syscalls, not ioctls.

"Don't do that".  You'll lose the ability to access the operations on
the fd once you are no longer the original task (explicit check).,

It's not an exact match, but a file is a remarkably convenient
abstraction for a non-ABI such as lguest.  Of course, Carsten was
talking about unifying the lguest & kvm userspace interface, so this
could well change anyway.

Cheers,
Rusty.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/