Re: x86: Convert cpu_core_map to be a per cpu variable

[Christoph Lameter]

On Fri, 13 Jul 2007, David Miller wrote:

> I see, the acessor is abstracted via a function.

Yes. The accessor for the scheduler is defined for each arch in topology.c

> That seems pointless, and allows you to do things like this, improving
> the implementation on one set of platforms yet leave others using
> SMT/multi-core scheduling behind.
> 
> It makes a lot more sense to make the implementation consistent
> and therefore the improvements are seen on every platform.

Slight differences exist on each platform. I already have enough trouble 
here right now to deal with the x86_64 overlap into i386. There are 
numerous other x86 specific maps that will have to be treated the same way 
and they are all handled in arch specific files.

Core cpu and node maps exist in the page allocator and are defined in 
nodemask.h and cpumask.h. I have recently introduced a framework that 
allows the definition of new masks that could be used in the future to 
abstract these out of the arches (See the memoryless node patchees). But 
that work has not been merged yet and is likely going to be a separate 
project.


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/