Re: [PATCH 1/3] Blackfin ethernet driver: on chip ethernet MAC controllerdriver

[Jeff Garzik]

Michael Buesch wrote:
> Well, this bitfield _might_ be OK (although I don't like bitfields
> at all), but the above pointer casting stuff should really use
> leXX_to_cpu. It's so easy to use and it is easier to read and
> maintain the code afterwards.
> If the bitfield stays, a comment must be added.

Regardless of endian issues, the bitfield usage should go away.

	Jeff


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/