Re: [PATCH 1/12] drivers/isdn/hisax/avm_pci.c: replace pci_find_devicewith pci_get_device

[Jeff Garzik]

To be more clear, your solution is incorrect unless the pci_dev_put() 
occurs after the last reference to hw.{elsa,diva,hfc,njet,...}.dev, 
which is where the HiSax ISDN drivers store their reference to struct 
pci_dev during the runtime life of the PCI device.

Am I missing where your patch does this?

By way of further interest, a few hours _before_ (yes, really) I saw 
your patches, I resumed converting the ISDN HiSax PCI drivers to use the 
PCI driver API.  You can find this work in 
git://git.kernel.org/.../jgarzik/misc-2.6.git#isdn-pci.

If you fix your patches' lifetime problems, I will ACK them myself, 
since my effort is a spare time effort.  But just wanted you to be aware 
that I am deep into the code you are fixing, and can at least speak 
somewhat knowledgeably on the specific lines of code you are changing.

	Jeff



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/